-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): should generate css assets even if the imported css file is empty #2759
Conversation
|
I did some investigation at #2747. But the PR was reverted due to causing some tests failed. You might get some inspiration from it. Feel free to ping me if you have any questions. |
👌 |
How to detect this alert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Thank you!
… empty (web-infra-dev#2759) * fix: 2670 * test * chore: add test * fix: test case * chore: rm gitpod
Summary
Fixes #2670
🤖 Generated by Copilot at 0fb3f68
This pull request enhances the
rspack_plugin_css
plugin, adds a new test fixture for importing empty CSS files, and fixes some minor code style issues. The changes aim to improve the functionality, reliability, and consistency of therspack
web development tool.Related issue (if exists)
Walkthrough
🤖 Generated by Copilot at 0fb3f68
style.module.css
file (link)package.json
file to import-empty-css-file fixture (link)rspack.config.js
file to import-empty-css-file fixture (link)empty.js
file that imports an empty CSS file (link)index.html
file that displays test result (link)index.js
file that dynamically importsempty.js
and sets text to "ok" (link)index.test.ts
file that asserts importing empty CSS file does not throw error (link)ResolveSwcPlugin.ts
(link)pnpm-lock.yaml
(link)