Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve structrue of PULL_REQUEST_TEMPLATE.md #2769

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

hyf0
Copy link
Collaborator

@hyf0 hyf0 commented Apr 16, 2023

Summary

Move the Related issue part to the top, which is the only part requested to be written manually.

馃 Generated by Copilot at dcc8f8b

Swapped the order of Related issue and Summary sections in the pull request template file .github/PULL_REQUEST_TEMPLATE.md to improve visibility and consistency.

Related issue (if exists)

Walkthrough

馃 Generated by Copilot at dcc8f8b

  • Swap the order of the Related issue and Summary sections in the pull request template (link). This makes the related issue more visible and follows the convention of other repositories in the web-infra-dev organization. The pull request template is in the file .github/PULL_REQUEST_TEMPLATE.md.

@hyf0 hyf0 requested a review from hardfist as a code owner April 16, 2023 13:17
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2023

鈿狅笍 No Changeset found

Latest commit: dcc8f8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 16, 2023
@hyf0 hyf0 enabled auto-merge April 16, 2023 13:19
@hyf0 hyf0 added this pull request to the merge queue Apr 16, 2023
Merged via the queue into main with commit 5fecaa6 Apr 16, 2023
6 checks passed
@hyf0 hyf0 deleted the 1283098129090581209309812093 branch April 16, 2023 14:23
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants