Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redirect name_for_condition in BoxModule #2778

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix: redirect name_for_condition in BoxModule #2778

merged 1 commit into from
Apr 17, 2023

Conversation

hyf0
Copy link
Collaborator

@hyf0 hyf0 commented Apr 17, 2023 •
edited by ghost

Related issue (if exists)

Summary

馃 Generated by Copilot at aa048c9

Add name_for_condition method to Module trait and use it in ModuleGraph. This allows generating descriptive names for modules based on some condition when showing the dependency graph.

Walkthrough

馃 Generated by Copilot at aa048c9

  • Implement name_for_condition method for Module trait object (link)

@hyf0 hyf0 requested a review from h-a-n-a as a code owner April 17, 2023 08:48
@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2023

鈿狅笍 No Changeset found

Latest commit: aa048c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added release: bug fix team The issue/pr is created by the member of Rspack. labels Apr 17, 2023
@hyf0
Copy link
Collaborator Author

hyf0 commented Apr 17, 2023

@hardfist This fix would correct the behaviors of splitChunks but would make big changes to the output of the non-fixed version.

You could see the details part at #2762 for more context.

@hyf0 hyf0 added this pull request to the merge queue Apr 17, 2023
Merged via the queue into main with commit e0d874d Apr 17, 2023
12 checks passed
@hyf0 hyf0 deleted the fix_32q08489023894090238423409e branch April 17, 2023 09:07
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
@hyf0 @siyou
fix: redirect name_for_condition in BoxModule (web-infra-dev#2778)
9755ee9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hyf0 @h-a-n-a