Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compatible compilation.modules #2932

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Apr 25, 2023

Related issue (if exists)

  1. Closed Rspack incompatibile with generate-package-json-webpack-plugin #2719

Summary

🤖 Generated by Copilot at 9eb3a4e

This pull request adds a getter method for the modules property of the Compilation class in packages/rspack/src/compilation.ts. This allows other classes, such as the ModuleGraph, to access the modules of the compilation.

Walkthrough

🤖 Generated by Copilot at 9eb3a4e

  • Add a getter method for the modules property of the Compilation class (link)

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

⚠️ No Changeset found

Latest commit: 6ee4944

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added release: feature team The issue/pr is created by the member of Rspack. labels Apr 25, 2023
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 25, 2023 10:49
hyf0
hyf0 previously approved these changes Apr 25, 2023
@hardfist
Copy link
Contributor

!bench

@hyf0
Copy link
Collaborator

hyf0 commented Apr 26, 2023

!bench

I don't think this would affect the current benchmark cases. compilation.modules is computed lazily.

@github-actions
Copy link
Contributor

Benchmark Results

group                                                 baseline                               pr
-----                                                 --------                               --
criterion_benchmark/ten_copy_of_threejs               1.00       2.4±0.13s        ? ?/sec    1.02       2.4±0.07s        ? ?/sec
high_cost_benchmark/ten_copy_of_threejs_production    1.00       8.3±0.13s        ? ?/sec    1.01       8.4±0.11s        ? ?/sec

@github-actions
Copy link
Contributor

Benchmark Results

group                                                 baseline                               pr
-----                                                 --------                               --
criterion_benchmark/ten_copy_of_threejs               1.01       2.9±0.09s        ? ?/sec    1.00       2.9±0.09s        ? ?/sec
high_cost_benchmark/ten_copy_of_threejs_production    1.00       9.9±0.16s        ? ?/sec    1.02      10.1±0.15s        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 26, 2023
Merged via the queue into main with commit c684075 Apr 26, 2023
12 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the fix/compilation-modules branch April 26, 2023 06:29
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
* feat: add compatible compilation.modules

* chore: 🤖 compatible identifier

* chore: 🤖 update dep

* chore: add examples plugin-compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rspack incompatibile with generate-package-json-webpack-plugin
3 participants