Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing newSplitChunks in schema.js #2934

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

hyf0
Copy link
Collaborator

@hyf0 hyf0 commented Apr 25, 2023

Related issue (if exists)

Summary

馃 Generated by Copilot at 5a8bea2

This pull request enhances the webpack configuration schema for rspack by adding SplitChunksPlugin support and fixing TypeScript errors. It affects the optimization and externals options in schema.js.

Walkthrough

馃 Generated by Copilot at 5a8bea2

  • Add a new option newSplitChunks to enable the new SplitChunksPlugin for chunk splitting (link)
  • Remove the tsType property from the function option of the externals schema to fix TypeScript errors (link)

@hyf0 hyf0 requested a review from hardfist as a code owner April 25, 2023 09:37
@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

鈿狅笍 No Changeset found

Latest commit: 5a8bea2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hyf0 hyf0 requested review from ahabhgk and removed request for hardfist April 25, 2023 09:37
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 25, 2023
@hyf0 hyf0 enabled auto-merge April 25, 2023 09:38
@hyf0 hyf0 added this pull request to the merge queue Apr 25, 2023
Merged via the queue into main with commit fb7802a Apr 25, 2023
11 checks passed
@hyf0 hyf0 deleted the fix_38902384908239084908243 branch April 25, 2023 09:42
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants