Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(plugin): asyncify optimize_chunks hook #2958

Merged
merged 1 commit into from
Apr 28, 2023
Merged

refactor(plugin): asyncify optimize_chunks hook #2958

merged 1 commit into from
Apr 28, 2023

Conversation

hyf0
Copy link
Collaborator

@hyf0 hyf0 commented Apr 27, 2023 •
edited

Related issue (if exists)

Summary

  • Preparation for calling JS function in optimize_chunks.

copilot:summary

Walkthrough

copilot:walkthrough

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

⚠️ No Changeset found

Latest commit: bdea3cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 27, 2023
@hyf0 hyf0 enabled auto-merge April 27, 2023 08:29
@hyf0 hyf0 requested review from ahabhgk and IWANABETHATGUY and removed request for h-a-n-a and underfin April 27, 2023 08:38
@hyf0 hyf0 added this pull request to the merge queue Apr 28, 2023
Merged via the queue into main with commit 92545fb Apr 28, 2023
13 of 14 checks passed
@hyf0 hyf0 deleted the hyf_31884092384908209384 branch April 28, 2023 03:06
IWANABETHATGUY pushed a commit that referenced this pull request Apr 28, 2023
@hyf0 @IWANABETHATGUY
refactor(plugin): asyncify optimize_chunks hook (#2958)
754aedf
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
@hyf0 @siyou
refactor(plugin): asyncify optimize_chunks hook (web-infra-dev#2958)
04c245c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hyf0 @IWANABETHATGUY