Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-rspack): add template react-ts #2963

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

wood3n
Copy link
Contributor

@wood3n wood3n commented Apr 27, 2023

Related issue (if exists)

Summary

add react+typescript template for create-rspack.

@wood3n wood3n requested a review from hardfist as a code owner April 27, 2023 11:41
@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

🦋 Changeset detected

Latest commit: 8b38f08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-rspack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2023

CLA assistant check
All committers have signed the CLA.

@hardfist
Copy link
Contributor

!canary

@wood3n
Copy link
Contributor Author

wood3n commented Apr 28, 2023

!canary

sry.i don't understand your mean😂

@hardfist
Copy link
Contributor

!canary

sry.i don't understand your mean😂

just trigger a canary release

@wood3n
Copy link
Contributor Author

wood3n commented Apr 28, 2023

!canary

sry.i don't understand your mean😂

just trigger a canary release

ok,i'll change it.

@wood3n
Copy link
Contributor Author

wood3n commented Apr 28, 2023

@hardfist excuse me, do i need to change anything? can you help me? 🤣

@hardfist
Copy link
Contributor

@hardfist excuse me, do i need to change anything? can you help me? 🤣

no need, thanks

@wood3n
Copy link
Contributor Author

wood3n commented Apr 28, 2023

@hardfist excuse me, do i need to change anything? can you help me? 🤣

no need, thanks

ok, thanks. 👍

@hyf0 hyf0 added this pull request to the merge queue Apr 28, 2023
Merged via the queue into web-infra-dev:main with commit 2fe8c47 Apr 28, 2023
9 of 10 checks passed
@wood3n wood3n deleted the chore_template_react_ts_wo branch May 4, 2023 02:07
@github-actions github-actions bot mentioned this pull request May 9, 2023
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants