Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 馃 disable css erorr #2964

Merged
merged 2 commits into from
Apr 28, 2023
Merged

chore: 馃 disable css erorr #2964

merged 2 commits into from
Apr 28, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Apr 27, 2023

Related issue (if exists)

Summary

馃 Generated by Copilot at 09b1bed

Improved CSS error handling in rspack_plugin_css crate. Removed unused code and imports, and ignored non-fatal errors to speed up processing and avoid unnecessary warnings.

Walkthrough

馃 Generated by Copilot at 09b1bed

  • Remove unused imports of error and diagnostic types (link)
  • Simplify error handling for CSS parsing by returning an internal error with the original message and no diagnostics, instead of converting the errors into warnings (link, link)
  • Comment out unused css_parse_error_to_diagnostic function that performed the conversion (link)

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

鈿狅笍 No Changeset found

Latest commit: ad001b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 27, 2023
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 28, 2023
Merged via the queue into main with commit c29e72a Apr 28, 2023
10 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the fix/disable-css-error branch April 28, 2023 10:05
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
* chore: 馃 disable css erorr

* chore: 馃 update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants