Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove clap #2967

Merged
merged 5 commits into from
May 4, 2023
Merged

chore: remove clap #2967

merged 5 commits into from
May 4, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Apr 27, 2023

Related issue (if exists)

Summary

According to the compilation profile
image
clap cost a pretty long time to compile which ranks 11 ordered by compilation time of crate`.
Using small crate to parsing args could reducing the compilation time.

馃 Generated by Copilot at 45bebec

This pull request replaces clap with argh for command-line argument parsing in the cargo-rst and rspack_ast_viewer subcrates. This reduces the number of dependencies, simplifies the code, and improves the user experience. The crates/cargo-rst/src/main.rs file is deleted as it is no longer needed.

Walkthrough

馃 Generated by Copilot at 45bebec

  • Replace clap with argh for command-line argument parsing in cargo-rst and rspack_ast_viewer subcrates (link, link, link, link, link, link, link, link, link)
  • Delete cargo-rst/src/main.rs file as it is no longer needed (link)

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

鈿狅笍 No Changeset found

Latest commit: 650ebed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@IWANABETHATGUY IWANABETHATGUY changed the title Feat/remove clap chore: remove clap Apr 27, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 27, 2023
@Boshen
Copy link
Contributor

Boshen commented Apr 27, 2023

Nice! 馃崡

@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/remove-clap branch 3 times, most recently from f16c104 to 978a8c5 Compare May 3, 2023 06:38
Copy link
Collaborator

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit 7fb3dd9 May 4, 2023
12 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the feat/remove-clap branch May 4, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants