-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract comments #2970
Conversation
|
64bf168
to
7e8bf06
Compare
@hyf0 fixed latest ci error, would you mind approving again? |
* chore: 馃 init * chore: 馃 refactor extract comments * chore: 馃 recover main scripts dir * refactor: 馃挕 refactor * chore: 馃 more test case * chore: 馃 fix ci
Related issue (if exists)
Summary
馃 Generated by Copilot at 7e8bf06
Improved the comment extraction feature in the
rspack_plugin_javascript
crate. Refactored and simplified the code inminify.rs
andplugin.rs
to avoid unnecessary sources and comments.Walkthrough
馃 Generated by Copilot at 7e8bf06
ConcatSource
inminify.rs
(link)CommentKind
inminify.rs
to handle different types of comments (link)minify.rs
by using a vector of strings instead of aConcatSource
(link, link)minify.rs
(link, link)extract_comments
variable toextract_comments_option
inplugin.rs
to avoid confusion with the function name (link, link)plugin.rs
(link)