Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rspack): add ignoreWarnings option #2987

Merged
merged 8 commits into from
May 4, 2023

Conversation

nagy-nabil
Copy link
Contributor

@nagy-nabil nagy-nabil commented Apr 29, 2023

Close #2979

  • add ignoreWarnings option in rspack options schema
  • add compilation.hooks.processWarnings
  • create ignoreWarnings plugin
  • activate the plugin when the user enter ignoreWarnings option

Known Limitations

  • eslint warnings get passed to the plugin as one error so with ignoreWarnings you got all eslint warnings or not

- [x] add `ignoreWarnings` option in rspack options schema
@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2023

🦋 Changeset detected

Latest commit: 938f273

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@rspack/core Patch
@rspack/cli Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
webpack-test Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/postcss-loader Patch
@rspack/dev-client Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2023

CLA assistant check
All committers have signed the CLA.

- WIP create ignore warnings plugin
- activite the plugin when the user supply ignoreWarnings option
- user can enter ignoreWarnings opt as regex or function returns bool
- add complilation processWarnings hook
- utilize processWarnings hook in ignoreWarnings plugin
@nagy-nabil nagy-nabil changed the title feat(user option):add ignoreWarnings option feat(rspack):add ignoreWarnings option May 1, 2023
@nagy-nabil nagy-nabil changed the title feat(rspack):add ignoreWarnings option feat(rspack): add ignoreWarnings option May 1, 2023
ahabhgk

This comment was marked as outdated.

@ahabhgk ahabhgk dismissed their stale review May 3, 2023 14:31

changeset file needs change

.changeset/olive-lobsters-tie.md Outdated Show resolved Hide resolved
@ahabhgk
Copy link
Collaborator

ahabhgk commented May 4, 2023

CI failed, snapshot should update

@nagy-nabil
Copy link
Contributor Author

@ahabhgk i updated the inline snapshot in defaults.unittest, am I missing anything else?

Copy link
Collaborator

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ahabhgk ahabhgk added this pull request to the merge queue May 4, 2023
Merged via the queue into web-infra-dev:main with commit bce8523 May 4, 2023
9 checks passed
This was referenced May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignoreWarnings for filter warnings
4 participants