Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: pnpm install command fix based on engine #2992

Merged
merged 1 commit into from
May 3, 2023
Merged

docs: pnpm install command fix based on engine #2992

merged 1 commit into from
May 3, 2023

Conversation

thedeveloperpotato
Copy link
Contributor

Summary

Just a small fix on CONTRIBUTING.md as currently pnpm@7.32.0 is forced by engine definition in package.json.

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023 •
edited

⚠️ No Changeset found

Latest commit: 91b3899

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented May 2, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@thedeveloperpotato thedeveloperpotato force-pushed the contributing-pnpm-version-update branch from 5e840cd to 91b3899 Compare May 2, 2023 20:42
@hardfist hardfist enabled auto-merge May 3, 2023 04:04
@hardfist hardfist added this pull request to the merge queue May 3, 2023
Merged via the queue into web-infra-dev:main with commit 2dcdbe8 May 3, 2023
4 checks passed
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
@thedeveloperpotato @siyou
docs: pnpm install command fix based on engine (web-infra-dev#2992)
10c585c
@github-actions github-actions bot mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thedeveloperpotato @CLAassistant @hyf0 @hardfist