Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): use directory for chunk_graph module #2998

Merged
merged 1 commit into from
May 3, 2023
Merged

refactor(core): use directory for chunk_graph module #2998

merged 1 commit into from
May 3, 2023

Conversation

hyf0
Copy link
Collaborator

@hyf0 hyf0 commented May 3, 2023

Related issue (if exists)

Summary

  • No logic changes. I just copy the original content to mod.rs.

ChunkGraph is a very huge struct and has a lot of methods. After using the directory, we could split some methods into other files to reduce potential conflicts in the future.

copilot:summary

Walkthrough

copilot:walkthrough

@hyf0 hyf0 requested a review from h-a-n-a as a code owner May 3, 2023 11:30
@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

⚠️ No Changeset found

Latest commit: 4b6911b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 3, 2023
@hyf0 hyf0 requested a review from hardfist May 3, 2023 11:30
@hyf0 hyf0 added this pull request to the merge queue May 3, 2023
Merged via the queue into main with commit 9b6aaa9 May 3, 2023
9 checks passed
@hyf0 hyf0 deleted the hyf_91234923098489023 branch May 3, 2023 11:34
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
@hyf0 @siyou
refactor(core): use directory for chunk_graph module (web-infra-dev#2998
7c7c056 
)
@github-actions github-actions bot mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hyf0 @hardfist