Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add add loader_name to loader_sync_call in trace #2999

Merged
merged 1 commit into from
May 4, 2023

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented May 4, 2023

Related issue (if exists)

when we need to debug performance problems, loader_name is very useful for finding the bottleneck of loader cost
image

Summary

馃 Generated by Copilot at 7ab3758

Add loader_name field to tracing span in js_loader.rs. This field shows the name of the js loader used for a module, instead of the full path, to improve readability.

Walkthrough

馃 Generated by Copilot at 7ab3758

  • Extract the loader name from the loader path and add it as a field to the tracing span (link)

@hardfist hardfist requested a review from h-a-n-a as a code owner May 4, 2023 03:57
@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

鈿狅笍 No Changeset found

Latest commit: acbc0c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 4, 2023
@hardfist hardfist force-pushed the add-loader-name branch 2 times, most recently from 92207d7 to d6f974f Compare May 4, 2023 08:34
@hardfist hardfist added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit cc635e9 May 4, 2023
10 checks passed
@hardfist hardfist deleted the add-loader-name branch May 4, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants