Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make release profile the same for Cargo.toml and node_binding/Cargo.toml #3004

Merged
merged 1 commit into from
May 4, 2023

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented May 4, 2023

Related issue (if exists)

Summary

🤖 Generated by Copilot at 8acfd97

This pull request improves the performance and size of the node binding crate and tests the changes in the nightly workflow. It modifies the Cargo.toml files in the root and the crates/node_binding directory, the .github/workflows/release-nightly.yml file, and the .github/actions/docker-build/action.yml file. It also temporarily disables the npm publishing step in the nightly workflow.

Walkthrough

🤖 Generated by Copilot at 8acfd97

  • Add a new trigger for the release-nightly workflow to run on push events to the same-cargo-toml branch (link)
  • Comment out the release job in the release-nightly workflow to avoid publishing broken or unwanted packages while testing (link)
  • Specify the common dependencies for the workspace in the root Cargo.toml file and sort them alphabetically (link)
  • Improve the performance and size of the binaries by enabling codegen-units, strip, and opt-level, and disabling debug and incremental in the release profile of the root Cargo.toml file (link)
  • Align the compiler options for the node binding crate with the root Cargo.toml file and comment out the debug option in the release profile of the crates/node_binding/Cargo.toml file (link)
  • List the node binding files after building them with pnpm in the docker-build action for debugging purposes (link)

@Boshen Boshen requested a review from h-a-n-a as a code owner May 4, 2023 07:57
@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

⚠️ No Changeset found

Latest commit: b55242f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 4, 2023
@Boshen Boshen added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit 8c0f855 May 4, 2023
18 of 20 checks passed
@Boshen Boshen deleted the same-cargo-toml branch May 4, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants