Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: external module for http request #3023

Merged
merged 3 commits into from
May 5, 2023
Merged

refactor: external module for http request #3023

merged 3 commits into from
May 5, 2023

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented May 5, 2023

Related issue (if exists)

closes #2976

Summary

馃 Generated by Copilot at 92bae45

This pull request adds support for external dependencies for web or node presets with css experiments in the rspack project. It enhances the options, external_module, and visitors modules in the rspack_core, rspack_binding_options, and rspack_plugin_css crates, and updates the corresponding types and defaults in the rspack package. It also refactors and simplifies some logic in the normal_module_factory, import, external_plugin, and runtime modules, and adds a changeset file and some test cases for the new features.

Walkthrough

馃 Generated by Copilot at 92bae45

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2023

馃 Changeset detected

Latest commit: 717629b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@rspack/binding Patch
@rspack/core Patch
@rspack/postcss-loader Patch
webpack-test Patch
@rspack/cli Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/dev-client Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hyf0 hyf0 added the team The issue/pr is created by the member of Rspack. label May 5, 2023
@ahabhgk ahabhgk added this pull request to the merge queue May 5, 2023
Merged via the queue into main with commit f4c1f8d May 5, 2023
9 of 10 checks passed
@ahabhgk ahabhgk deleted the css-external branch May 5, 2023 12:18
This was referenced May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to config skip resolve protocol in css
3 participants