Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(chunk_graph): split methods of ChunkGraph into different files #3031

Merged
merged 1 commit into from
May 6, 2023

Conversation

hyf0
Copy link
Collaborator

@hyf0 hyf0 commented May 6, 2023

Related issue (if exists)

Summary

馃 Generated by Copilot at ec69ebd

This pull request refactors the code related to the chunk graph in rspack_core, a core library for a webpack-like bundler. It introduces two new modules, chunk_graph_chunk.rs and chunk_graph_module.rs, that define structs and methods for representing and manipulating the chunks and modules in the chunk graph. The goal of this refactoring is to improve the code quality, readability, and maintainability.

Walkthrough

馃 Generated by Copilot at ec69ebd

  • Refactor the chunk graph code into two new modules: chunk_graph_chunk.rs and chunk_graph_module.rs (link, link)
  • Define a struct ChunkGraphChunk that represents a chunk in the chunk graph and its methods (link)
  • Define a struct ChunkGraphModule that represents a module in the chunk graph and its methods (link)
  • Simplify and modularize the code related to the chunk graph logic and optimization (link, link)

@hyf0 hyf0 requested a review from h-a-n-a as a code owner May 6, 2023 04:50
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2023

鈿狅笍 No Changeset found

Latest commit: ec69ebd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 6, 2023
@hyf0 hyf0 added this pull request to the merge queue May 6, 2023
Merged via the queue into main with commit 525f2a6 May 6, 2023
14 checks passed
@hyf0 hyf0 deleted the hyf_2349029038590723 branch May 6, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants