-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: single workspace #3035
chore: single workspace #3035
Conversation
|
8ed1c75
to
ad7df35
Compare
Let's wait until Tuesday's release before rushing this into main. |
018e36f
to
173994f
Compare
183127f
to
cee2f89
Compare
381bf33
to
9d5e6e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you save my day
chore: migrate the node_binding crate into the main workspace
Summary
This PR puts
crates/node_binding
under the same workspace.馃 Generated by Copilot at e93556b
This pull request experiments with a new workspace structure and a new enum for loading JavaScript code in
rspack
. It updates the test workflow, refactors and cleans up thenode_binding
andrspack_binding_options
crates, and fixes a napi issue in the test environment. It also modifies theCargo.toml
files and the.cargo/config.toml
file to support the new workspace and the new resolver.Walkthrough
馃 Generated by Copilot at e93556b
one-workspace
branch and to add more target architectures (link, link)node_binding
andrspack
crates from the workspace, and use the new resolver for feature unification (link)node-api
feature from therspack_binding_options
crate, and use aJsLoaderRunner
enum instead of aThreadsafeFunction
struct for the loader runner parameter of theapply
methods of theRawOptions
and its substructures (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)crate-type = ["lib", "cdylib"]
option to thelib
section of therspack_binding_options
crate (link)profile.release
section from thenode_binding
crate (link)rspack
in thedev-dependencies
section of therspack_error
crate (link)&JsLoaderRunner::noop()
argument to theapply
methods of theraw
variables in thebuild-cli.rs
example file and therun_fixture.rs
file of therspack_testing
crate (link, link, link, link)crates/rspack_binding_options/build.rs
file (link)