Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: single workspace #3035

Merged
merged 1 commit into from
May 9, 2023
Merged

chore: single workspace #3035

merged 1 commit into from
May 9, 2023

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented May 6, 2023

Summary

This PR puts crates/node_binding under the same workspace.

馃 Generated by Copilot at e93556b

This pull request experiments with a new workspace structure and a new enum for loading JavaScript code in rspack. It updates the test workflow, refactors and cleans up the node_binding and rspack_binding_options crates, and fixes a napi issue in the test environment. It also modifies the Cargo.toml files and the .cargo/config.toml file to support the new workspace and the new resolver.

Walkthrough

馃 Generated by Copilot at e93556b

  • Add a linker argument to fix a napi issue in the test environment (link)
  • Modify the GitHub workflow for testing pull requests to only run on the one-workspace branch and to add more target architectures (link, link)
  • Comment out the exclusion of the node_binding and rspack crates from the workspace, and use the new resolver for feature unification (link)
  • Remove the node-api feature from the rspack_binding_options crate, and use a JsLoaderRunner enum instead of a ThreadsafeFunction struct for the loader runner parameter of the apply methods of the RawOptions and its substructures (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Add the crate-type = ["lib", "cdylib"] option to the lib section of the rspack_binding_options crate (link)
  • Remove the profile.release section from the node_binding crate (link)
  • Comment out the dependency on rspack in the dev-dependencies section of the rspack_error crate (link)
  • Add the &JsLoaderRunner::noop() argument to the apply methods of the raw variables in the build-cli.rs example file and the run_fixture.rs file of the rspack_testing crate (link, link, link, link)
  • Delete the crates/rspack_binding_options/build.rs file (link)

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2023

鈿狅笍 No Changeset found

Latest commit: 381bf33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

.github/workflows/test-pr.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 6, 2023
@hyf0 hyf0 self-requested a review May 6, 2023 10:00
@Boshen Boshen marked this pull request as ready for review May 6, 2023 10:53
@Boshen Boshen force-pushed the one-workspace branch 3 times, most recently from 8ed1c75 to ad7df35 Compare May 6, 2023 10:56
hyf0
hyf0 previously approved these changes May 6, 2023
Cargo.toml Outdated Show resolved Hide resolved
crates/rspack_binding_options/Cargo.toml Outdated Show resolved Hide resolved
@Boshen Boshen marked this pull request as draft May 6, 2023 11:03
@Boshen
Copy link
Contributor Author

Boshen commented May 6, 2023

Let's wait until Tuesday's release before rushing this into main.

@Boshen Boshen force-pushed the one-workspace branch 3 times, most recently from 018e36f to 173994f Compare May 8, 2023 03:28
@hyf0 hyf0 self-requested a review May 8, 2023 03:31
@hyf0 hyf0 self-assigned this May 8, 2023
@hyf0 hyf0 added this to the 0.1.11 - Patch milestone May 8, 2023
@Boshen Boshen force-pushed the one-workspace branch 3 times, most recently from 183127f to cee2f89 Compare May 8, 2023 06:58
@Boshen Boshen force-pushed the one-workspace branch 3 times, most recently from 381bf33 to 9d5e6e0 Compare May 9, 2023 09:21
@Boshen Boshen marked this pull request as ready for review May 9, 2023 09:34
Copy link
Collaborator

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you save my day

@Boshen Boshen enabled auto-merge May 9, 2023 10:29
@Boshen Boshen added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit 9d1bee6 May 9, 2023
11 checks passed
@Boshen Boshen deleted the one-workspace branch May 9, 2023 11:01
IWANABETHATGUY pushed a commit that referenced this pull request May 9, 2023
chore: migrate the node_binding crate into the main workspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants