feat: optional-dependency #3050
Conversation
|
suxin2017
requested review from
hardfist,
ahabhgk,
h-a-n-a and
hyf0
as code owners
| node: &'ast swc_core::ecma::ast::TryStmt, | ||
| ast_path: &mut swc_core::ecma::visit::AstNodePath<'r>, | ||
| ) { | ||
| self.in_try = true; |
There was a problem hiding this comment.
I currently could not come up with a problem case. But the code is kind of buggy.
It's better to store the old in_try value and then recover it for the nested try-catch block.
let old_in_try = self.in_try;
self.in_try = true
node.visit_children_with_path(self, ast_path);
self.in_try = old_in_tryThere was a problem hiding this comment.
I currently could not come up with a problem case. But the code is kind of buggy.
It's better to store the old
in_tryvalue and then recover it for the nested try-catch block.let old_in_try = self.in_try; self.in_try = true node.visit_children_with_path(self, ast_path); self.in_try = old_in_try
Do I need to submit an mr Again?
Related issue (if exists)
#3042
Summary
馃 Generated by Copilot at 0064be7
This pull request adds support for ignoring
requirecalls inside try-catch blocks in therspack_plugin_javascriptcrate. It also adds a new test case with fixture files to verify the functionality.Walkthrough
馃 Generated by Copilot at 0064be7
in_trytoDependencyScannerto track try statements (link)visit_try_stmtmethod to set and resetin_tryfield (link)visit_exprmethod to skiprequirecalls inside try blocks (link)index.jswith arequirecall inside a try-catch block (link)expected/main.jswith the expected output of the plugin (link)test.config.jsonwith the configuration for the plugin (link)