Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 馃悰 cross compile #3059

Merged
merged 1 commit into from
May 8, 2023
Merged

fix: 馃悰 cross compile #3059

merged 1 commit into from
May 8, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented May 8, 2023 •
edited by ghost

Related issue (if exists)

Summary

馃 Generated by Copilot at 43e0d59

Enable cross-compilation of node bindings using Zig. Modify build.js to use --cross-compile flag instead of --zig flag when USE_ZIG is set.

Walkthrough

馃 Generated by Copilot at 43e0d59

  • Enable cross-compilation of node bindings using Zig compiler (link)

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023 •
edited

鈿狅笍 No Changeset found

Latest commit: 2051094

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added release: bug fix team The issue/pr is created by the member of Rspack. labels May 8, 2023
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue May 8, 2023
Merged via the queue into main with commit 4cd0505 May 8, 2023
14 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the fix/canary-compile branch May 8, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@hyf0 hyf0 hyf0 approved these changes

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IWANABETHATGUY @h-a-n-a @hyf0