Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: take bump check temporarily #3064

Merged
merged 2 commits into from
May 9, 2023
Merged

chore: take bump check temporarily #3064

merged 2 commits into from
May 9, 2023

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented May 9, 2023

Related issue (if exists)

Summary

馃 Generated by Copilot at 4d6a3a6

Commented out checkBump function in scripts/check_changeset.js to skip version checking for testing. This is a temporary change for a feature branch.

Walkthrough

馃 Generated by Copilot at 4d6a3a6

  • Disable the version bump check for testing purposes (link). This change affects the scripts/check_changeset.js file, which runs a script to validate the changeset files before committing them. The checkBump function call was commented out to allow testing the changeset functionality without following the semantic versioning rules.

@hardfist hardfist requested review from Boshen and hyf0 as code owners May 9, 2023 01:20
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 9, 2023
Copy link
Contributor

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, always make a comment on why it's commented out, either in the commit message or inline.

scripts/check_changeset.js Outdated Show resolved Hide resolved
@Boshen Boshen added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit a240646 May 9, 2023
10 checks passed
@Boshen Boshen deleted the take-bump-check branch May 9, 2023 03:29
IWANABETHATGUY pushed a commit that referenced this pull request May 9, 2023
* chore: use changeset status to check bump status

* Update scripts/check_changeset.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants