refactor(hmr): change visit_node_children from macro to fn #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
underfin
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
Summary
馃 Generated by Copilot at 85e3fd3
Refactored the
HmrDependencyScannerstruct in therspack_plugin_javascriptcrate to use a closure instead of a macro for visiting node children. This improved code readability and reduced complexity.Walkthrough
馃 Generated by Copilot at 85e3fd3
visit_node_childrenwith a closure of the same name to simplify code and avoid unnecessary macros inhmr_scanner.rs(link)selfreference explicitly inHmrDependencyScannermethods for handlingimport.meta.hot.acceptandimport.meta.hot.declinenodes (link, link)