Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): remove unused eslint-loader from examples/eslint #3123

Merged
merged 1 commit into from
May 12, 2023

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented May 11, 2023

Summary

eslint-loader is deprecated by the way.

馃 Generated by Copilot at 65a51d1

This pull request updates the code quality tools and configuration for the examples/eslint project. It upgrades eslint and eslint-rspack-plugin to the latest versions, fixes some dependency issues in the lockfile, and applies the new linting rules to the code.

Walkthrough

馃 Generated by Copilot at 65a51d1

  • Update eslint and eslint-rspack-plugin dependencies to latest versions in examples/eslint/package.json (link,link)
  • Sync eslint and eslint-rspack-plugin dependencies in pnpm-lock.yaml with examples/eslint/package.json (link,link)
  • Remove unused dependencies from pnpm-lock.yaml, such as @babel/code-frame, acorn-jsx, functional-red-black-tree, ignore, object-hash, regexpp, and v8-compile-cache (link,link,link,link,link,link,link)
  • Add new dependencies to pnpm-lock.yaml, such as @eslint-community/eslint-utils, @eslint-community/regexpp, @eslint/js, and js-sdsl, which are required by eslint version 8 (link,link,link,link)
  • Update existing dependencies in pnpm-lock.yaml to match the new versions of eslint and eslint-rspack-plugin, such as @eslint/eslintrc, @humanwhocodes/config-array, espree, and schema-utils (link,link,link,link,link,link,link)
  • Update @jest/types and jest-util dependencies in pnpm-lock.yaml to version 29.5.0, which is a minor update with some bug fixes and enhancements (link,link,link,link,link,link,link,link,link,link,link,link,link,link)
  • Fix dev property in pnpm-lock.yaml for @jest/fake-timers and @jest/source-map dependencies, to correctly reflect their usage as development or production dependencies (link,link)
  • Remove eslint-loader and eslint dependencies from pnpm-lock.yaml for examples/eslint project, as they are no longer used (link)

@Boshen Boshen requested a review from hardfist as a code owner May 11, 2023 11:03
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 11, 2023
@Boshen Boshen added this pull request to the merge queue May 12, 2023
Merged via the queue into main with commit 46d6afb May 12, 2023
15 checks passed
@Boshen Boshen deleted the rm-eslint-loader branch May 12, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants