Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rspack-cli): run jest with --runInBand #3140

Merged
merged 1 commit into from
May 15, 2023
Merged

chore(rspack-cli): run jest with --runInBand #3140

merged 1 commit into from
May 15, 2023

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented May 12, 2023

Related issue (if exists)

The flacky test may be caused by running tests in parallel.

Summary

馃 Generated by Copilot at d9881cc

Modified the test script in packages/rspack-cli/package.json to run jest tests serially. This fixes a memory issue with the GitHub Actions workflow.

Walkthrough

馃 Generated by Copilot at d9881cc

  • Modify the test script to use the --runInBand option for jest to avoid memory issues in GitHub Actions (link)

@Boshen Boshen requested a review from hardfist May 12, 2023 08:33
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 12, 2023
@Boshen Boshen enabled auto-merge May 12, 2023 08:37
@Boshen Boshen added this pull request to the merge queue May 15, 2023
Merged via the queue into main with commit fb4c97a May 15, 2023
17 checks passed
@Boshen Boshen deleted the cli_test branch May 15, 2023 08:31
@Boshen Boshen mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants