feat(core): external supports array #3141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
closes #1803
Summary
馃 Generated by Copilot at 3f82dc2
This pull request adds support for array values in external module configuration and simplifies the logic for handling different external types. It introduces a new
ExternalRequest
struct to represent the request of an external module as a vector of strings, and updates theExternalModule
struct and its methods accordingly. It also modifies theExternalItemValue
enum, theplugin.rs
file, and theumd_library_plugin.rs
file to use the new struct and handle array values.Walkthrough
馃 Generated by Copilot at 3f82dc2
ExternalRequest
struct to wrap external module requests as vectors of strings (link, link, link, link)ExternalModule
struct and methods to useExternalRequest
instead ofString
for request field and id generation (link, link, link, link, link, link)get_external_module
method inplugin.rs
to handleArray
variant ofExternalItemValue
and convert it toExternalRequest
(link, link)get_umd_library_source
method inumd_library_plugin.rs
to useas_str
method ofExternalRequest
to get first element of request vector (link)