refactor(rust): remove dead code #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boshen
requested review from
IWANABETHATGUY,
hyf0,
h-a-n-a and
ahabhgk
as code owners
github-actions
bot
added
the
team
hyf0
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
#![allow(dead_code)]at top level is a code smell.Summary
馃 Generated by Copilot at c2c967c
Removed unused code, fields, parameters, dependencies, and attributes from various crates in the
rspackproject to eliminate compiler warnings and improve code quality and readability. Updated a dependency version to avoid duplication. Deleted an unused file and module.Walkthrough
馃 Generated by Copilot at c2c967c
regex-syntaxdependency inrspack_regexcrate to avoid duplicate dependency warning (link)