Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export-all-from-side-effects-free-commonjs #3181

Merged
merged 5 commits into from
May 18, 2023
Merged

fix: export-all-from-side-effects-free-commonjs #3181

merged 5 commits into from
May 18, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented May 17, 2023 •
edited by ghost

Related issue (if exists)

Summary

馃 Generated by Copilot at 8445738

This pull request adds a new test case for tree-shaking commonjs modules that export all their properties. It verifies that webpack can eliminate unused exports from the bundle when the sideEffects flag is set to false in the package.json file.

Walkthrough

馃 Generated by Copilot at 8445738

  • Add webpack bootstrap code to main.js file (link)
  • Create index.js file as entry point of test case (link)
  • Create lib.js file as commonjs module (link)
  • Set sideEffects flag to false in package.json file (link)
  • Configure webpack options for test case in test.config.json file (link)

@github-actions github-actions bot added release: bug fix team The issue/pr is created by the member of Rspack. labels May 17, 2023
@IWANABETHATGUY IWANABETHATGUY force-pushed the fix/export-all-from-side-effects-free-commonjs branch 5 times, most recently from 0809f8c to 30aa5e7 Compare May 18, 2023 07:00
@IWANABETHATGUY IWANABETHATGUY force-pushed the fix/export-all-from-side-effects-free-commonjs branch from 30aa5e7 to 4ce3cb2 Compare May 18, 2023 07:01
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review May 18, 2023 07:19
underfin
underfin previously approved these changes May 18, 2023
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue May 18, 2023
@IWANABETHATGUY IWANABETHATGUY removed this pull request from the merge queue due to a manual request May 18, 2023
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue May 18, 2023
Merged via the queue into main with commit d8fc9bc May 18, 2023
12 of 13 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the fix/export-all-from-side-effects-free-commonjs branch May 18, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfin underfin underfin approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IWANABETHATGUY @underfin