Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resolve): support custom exports fields #3186

Merged
merged 1 commit into from
May 17, 2023

Conversation

bvanjoi
Copy link
Collaborator

@bvanjoi bvanjoi commented May 17, 2023

Related issue (if exists)

Summary

馃 Generated by Copilot at 9e42b02

Added support for custom exports fields in module resolution options for both Rust and webpack. Updated nodejs-resolver dependency and added a new test case for exports-fields. Removed an unused test file.

Walkthrough

馃 Generated by Copilot at 9e42b02

  • Update nodejs-resolver dependency to version 0.0.84 (link)
  • Add export_fields field to RawResolveOptions struct and map it to exports_field field in ResolveOptions struct (link, link, link)
  • Add exports_field field to ResolveOptions struct and assign it a default value of [["exports"]] (link, link)
  • Pass exports_field field to Resolve::new function and merge it with base and other options (link, link, link)
  • Add exportsFields field to webpack configuration and validate it with resolve schema (link, link, link)
  • Add exports-fields test case to test resolving modules with different exports fields (link, link, link)
  • Delete test.config.js file from resolve/conditions test case (link)

@github-actions github-actions bot added release: feature team The issue/pr is created by the member of Rspack. labels May 17, 2023
jerrykingxyz
jerrykingxyz previously approved these changes May 17, 2023
@jerrykingxyz jerrykingxyz added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit 1d38c8b May 17, 2023
12 checks passed
@jerrykingxyz jerrykingxyz deleted the custom-exports-fields branch May 17, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants