Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix arco-pro example crashing in debug mode #3192

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented May 17, 2023

Related issue (if exists)

Summary

馃 Generated by Copilot at ba2c5dc

This pull request improves the web app performance and fixes a transpiler error by modifying the rspack.config.js file in the arco-pro example. It disables source maps and aliases the mockjs module.

Walkthrough

馃 Generated by Copilot at ba2c5dc

  • Disable source map generation for production and development modes to reduce bundle size and improve performance (link)
  • Add alias for mockjs module to avoid stack overflow error when using swc transpiler in debug mode (link)

@Boshen Boshen requested a review from hardfist as a code owner May 17, 2023 10:28
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 17, 2023
@Boshen Boshen enabled auto-merge May 17, 2023 10:31
@Boshen Boshen added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit e8a8507 May 17, 2023
16 checks passed
@Boshen Boshen deleted the fix-mock-js branch May 17, 2023 10:59
resolve: {
alias: {
"@": path.resolve(__dirname, "src"),
// The default exported mock.js is a minified file with super deep binary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a minified file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants