Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix fix-issue-3873 crash #3196

Merged
merged 2 commits into from
May 17, 2023
Merged

chore: fix fix-issue-3873 crash #3196

merged 2 commits into from
May 17, 2023

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented May 17, 2023

Related issue (if exists)

since we don't clean dist folder it cause issue-3873 bundle dist/main.js recursively, which generates a complex dist/main.js cause swc stackoverflow

Summary

馃 Generated by Copilot at 3c9ff01

This pull request fixes a stack overflow error caused by mockjs when using swc in debug mode. It replaces mockjs with a custom mock module in the arco-pro example, and cleans up the output directory after each rspack test case.

Walkthrough

馃 Generated by Copilot at 3c9ff01

  • Replace mockjs module with custom mock module to avoid stack overflow error when parsed by swc in debug mode (link,link)
  • Remove output directory recursively after each test case in case.template.ts to keep test environment clean and consistent (link)

@hardfist hardfist requested review from Boshen and h-a-n-a and removed request for Boshen May 17, 2023 12:14
@hardfist hardfist changed the title chore: fix arco-pro crash again chore: fix fix-issue-3873 crash May 17, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 17, 2023
@hardfist hardfist enabled auto-merge May 17, 2023 12:22
@hardfist hardfist added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit 8e6f063 May 17, 2023
21 of 22 checks passed
@hardfist hardfist deleted the fix-issue-3873 branch May 17, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants