fix: wasm loading runtime on node-18 #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: bug fix
team
|
Broken on 16 馃ゲ |
Boshen
approved these changes
May 18, 2023
|
I'll merge once my node18 branch passes (rebased on top of your branch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
Summary
馃 Generated by Copilot at 6b63094
This pull request enhances the
rspack_plugin_wasmcrate to support streaming compilation of WebAssembly modules. It adds a new parameter and a new feature to theAsyncWasmLoadingRuntimeModulestruct and updates its constructor and code generation. This feature can improve performance for modules fetched from the public path.Walkthrough
馃 Generated by Copilot at 6b63094