Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix node16 tests #3200

Merged
merged 1 commit into from
May 17, 2023
Merged

chore: fix node16 tests #3200

merged 1 commit into from
May 17, 2023

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented May 17, 2023 •
edited by ghost

Related issue (if exists)

Summary

馃 Generated by Copilot at 775c826

Improve error handling in rspack bundler test case. Add a check for output path existence before deleting it in case.template.ts.

Walkthrough

馃 Generated by Copilot at 775c826

  • Add a check for output path existence before deleting it in a test case (link)

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 17, 2023
@Boshen Boshen enabled auto-merge May 17, 2023 15:08
@Boshen Boshen added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit 40f4e22 May 17, 2023
15 checks passed
@Boshen Boshen deleted the fix-node16 branch May 17, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hardfist @Boshen