Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix provide can't be override by user #3201

Merged
merged 2 commits into from
May 18, 2023
Merged

fix: fix provide can't be override by user #3201

merged 2 commits into from
May 18, 2023

Conversation

zhangliu
Copy link
Contributor

@zhangliu zhangliu commented May 18, 2023

Related issue (if exists)

#3190

Summary

after modification,user can customize the provide option。

Walkthrough

🤖 Generated by Copilot at dce5a70

  • Allow user to override default Node.js polyfills with custom implementations (link)

@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

@hardfist hardfist changed the title fix: 修复 provide 选项的顺序,让外部用户配置的能够覆盖默认值 fix: fix provide can't be override by user May 18, 2023
@hardfist
Copy link
Contributor

please sign the CLA

@zhangliu
Copy link
Contributor Author

have signed the CLA already but the status is still pending

i have signed the CLA already but the status is still pending,and click 「recheck」has no help。

@chenjiahan
Copy link
Member

@zhangliu Please check your email
image

@hyf0 hyf0 enabled auto-merge May 18, 2023 07:51
@hyf0 hyf0 added this pull request to the merge queue May 18, 2023
Merged via the queue into web-infra-dev:main with commit 3fca3fd May 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants