fix: 馃悰 amd external-array #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: bug fix
team
IWANABETHATGUY
force-pushed
the
fix/external-array-string
branch
from
cebc981
to
38968c8
Compare
hardfist
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
Summary
馃 Generated by Copilot at cebc981
Refactor
Modulestruct to useCow<'static, str>forrequestfield and updateformat!macro accordingly. This improves performance and memory usage inrspack_plugin_library.Walkthrough
馃 Generated by Copilot at cebc981
requestfield of theModulestruct to a&strbefore formatting it with single quotes (link) incrates/rspack_plugin_library/src/utils.rs. This avoids unnecessary allocations and cloning of strings.