Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up node dev dependencies #3229

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented May 19, 2023

Related issue (if exists)

Summary

馃 Generated by Copilot at c9b1adf

This pull request cleans up and improves the devDependencies of various packages in the web-infra-dev/rspack repository. It removes unused or redundant packages, fixes syntax errors, and updates the pnpm-lock.yaml file to match the changes. This enhances the code quality, compatibility, and performance of the rspack scripts and packages.

Walkthrough

馃 Generated by Copilot at c9b1adf

  • Remove unused packages cross-env, npm-run-all, and why-is-node-running from crates/node_binding/package.json (link)
  • Remove unnecessary dependency on @napi-rs/cli from crates/rspack_fs_node/package.json (link)
  • Add missing types for rimraf and node, and move cross-env from optionalDependencies to devDependencies in package.json (link)
  • Add npm-run-all to run multiple commands in parallel in package.json scripts (link)
  • Add why-is-node-running to debug memory leaks or hanging processes in package.json scripts (link)
  • Remove unused cross-env from packages/rspack-cli/package.json (link)
  • Remove duplicated types for node and rimraf from packages/rspack/package.json (link)
  • Remove unused rimraf from packages/rspack/package.json (link)
  • Remove trailing comma from packages/rspack/package.json to fix JSON syntax (link)
  • Update dependencies in pnpm-lock.yaml to reflect changes in package.json files (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
    • Add @types/rimraf and cross-env, and remove cross-env from optionalDependencies for rspack-cli (link)
    • Add npm-run-all for rspack-cli (link)
    • Add why-is-node-running for rspack-cli (link)
    • Add @types/rimraf and cross-env, and remove cross-env from optionalDependencies for rspack (link)
    • Add npm-run-all for rspack (link)
    • Add why-is-node-running for rspack (link)
    • Remove cross-env, npm-run-all, and why-is-node-running for node_binding (link)
    • Remove @napi-rs/cli for rspack_fs_node (link)
    • Remove @types/node and @types/rimraf for rspack (link, link)
    • Remove rimraf for rspack (link)
    • Remove @types/node and @types/rimraf for rspack-cli (link, link)
    • Remove rimraf for rspack-cli (link)
    • Update ts-node to remove peer dependency on @types/node for rspack-cli (link)
    • Remove unused entries for @napi-rs/cli and ts-node with peer dependency on @types/node (link, link)

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 19, 2023
h-a-n-a
h-a-n-a previously approved these changes May 19, 2023
crates/rspack_fs_node/package.json Outdated Show resolved Hide resolved
@Boshen Boshen added this pull request to the merge queue May 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2023
@Boshen Boshen added this pull request to the merge queue May 24, 2023
Merged via the queue into main with commit 99b9a92 May 24, 2023
13 checks passed
@Boshen Boshen deleted the clear-dev-dependencies branch May 24, 2023 07:30
@@ -54,18 +54,23 @@
"@taplo/cli": "^0.5.2",
"@types/jest": "29.1.0",
"@types/node": "16",
"@types/node": "16",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like repeated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants