feat: add cache idle hooks #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
IWANABETHATGUY
force-pushed
the
feat/cache-idle
branch
from
5cb8dcc
to
f0ffebf
Compare
IWANABETHATGUY
approved these changes
May 30, 2023
IWANABETHATGUY
force-pushed
the
feat/cache-idle
branch
from
f0ffebf
to
4c8c14f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
#3158
Summary
Similar to the shutdown hook, the idle hooks are used by ProgressPlugin to mark the end of a compilation.
馃 Generated by Copilot at 5cb8dcc
Added build status and cache management to
Compilerclass inpackages/rspack/src/compiler.ts. This improves the performance and reliability of the web packer tool.Walkthrough
馃 Generated by Copilot at 5cb8dcc
idleproperty toCompilerclass to indicate whether the compiler is idle or busy (link, link)idletotruebefore and after cleaning up cache inrunmethod ofCompilerclass (link)idleand restore cache state before executing build task inrunmethod ofCompilerclass (link)cache.endIdlemethod to take a callback function that setsidletofalseand calls build task function (link)