Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-client): remove some unused dependencies #3244

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented May 22, 2023

Related issue (if exists)

Summary

馃 Generated by Copilot at be9c619

This pull request updates the pnpm-lock.yaml file and the packages/rspack-dev-client/package.json file to remove some unnecessary dependencies and mark others as development-only. This improves the package installation and development process and reduces the bundle size.

Walkthrough

馃 Generated by Copilot at be9c619

  • Move development and testing dependencies from dependencies to devDependencies in packages/rspack-dev-client/package.json (link)
  • Update specifiers and dependencies fields for packages/rspack-dev-client in pnpm-lock.yaml to match the changes in package.json (link)
  • Change the hash of @pmmmwh/react-refresh-webpack-plugin dependency for packages/rspack-dev-client in pnpm-lock.yaml to reflect the updated version of the package (link)
  • Remove webpack-dev-server dependency for packages/rspack-dev-client from pnpm-lock.yaml as it is no longer needed (link, link)
  • Add dev field for packages/rspack-dev-client in pnpm-lock.yaml to indicate that the package is only used for development and testing purposes (link)

@chenjiahan chenjiahan requested a review from underfin May 22, 2023 06:47
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 22, 2023
@chenjiahan chenjiahan changed the title chore(dev-client): remove some unused dependencies fix(dev-client): remove some unused dependencies May 22, 2023
@underfin underfin added this pull request to the merge queue May 22, 2023
Merged via the queue into main with commit f4cab3b May 22, 2023
18 checks passed
@underfin underfin deleted the dev_client_0522 branch May 22, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants