Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: progressively migrate webpack test case #3256

Merged
merged 7 commits into from
May 23, 2023
Merged

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented May 22, 2023

Related issue (if exists)

Closed #3116

Summary

Here is an example,
before
image

I changewebpack-test/configCases/assets/delete-asset/test.filter.js to:

-module.exports = () => {return false}
+module.exports = () => {return -1}

after
image

馃 Generated by Copilot at 9cf6469

This pull request updates the webpack test cases and the compatibility report for rspack, and adds documentation on how to migrate and filter test cases. It also introduces a new formula for measuring the compatibility of rspack with webpack.

Walkthrough

馃 Generated by Copilot at 9cf6469

  • Add a section to the README file that explains the migration strategy and compatibility formula for webpack test cases (link)

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 22, 2023
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review May 23, 2023 03:09
@IWANABETHATGUY IWANABETHATGUY changed the title chore: 馃 filter test case doc: progressivly migrate webpack test case May 23, 2023
@IWANABETHATGUY IWANABETHATGUY changed the title doc: progressivly migrate webpack test case chore: progressivly migrate webpack test case May 23, 2023
@IWANABETHATGUY IWANABETHATGUY changed the title chore: progressivly migrate webpack test case chore: progressively migrate webpack test case May 23, 2023
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue May 23, 2023
Merged via the queue into main with commit 1fb78a1 May 23, 2023
11 of 12 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the chore/filter-test branch May 23, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add doc about how to filter test
3 participants