Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external amd array case #3268

Merged
merged 4 commits into from
May 24, 2023
Merged

fix: external amd array case #3268

merged 4 commits into from
May 24, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented May 23, 2023

Related issue (if exists)

Summary

馃 Generated by Copilot at 6afed73

This pull request adds a new example project to the examples/amd folder, which demonstrates how to use rspack with AMD modules and externals. It also fixes a bug in the utils.rs file of the rspack_plugin_library crate, which affected the JSON serialization of module requests.

Walkthrough

馃 Generated by Copilot at 6afed73

  • Fix a bug in JSON serialization of module requests (link)
  • Add an example project that uses AMD modules and externals (link, link, link, link)
    • Create a basic HTML template for the html builtin plugin (link)
    • Define the dependencies, scripts, and side effects for the project in package.json (link)
    • Configure the rspack CLI options for AMD output and externals in rspack.config.js (link)
    • Export a default function component named App that renders a div element in src/index.jsx (link)
  • Update the pnpm-lock.yaml file to include the new example project and its dependencies (link)

@IWANABETHATGUY IWANABETHATGUY changed the title Feat amd externals case fix: extern amd case May 23, 2023
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix labels May 23, 2023
@IWANABETHATGUY IWANABETHATGUY changed the title fix: extern amd case fix: external amd array case May 23, 2023
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue May 24, 2023
Merged via the queue into main with commit 5ff0c77 May 24, 2023
13 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the feat-amd-externals-case branch May 24, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants