Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add fork-ts-checker-webpack-plugin example #3269

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented May 23, 2023

Related issue (if exists)

Summary

馃 Generated by Copilot at 1b8237a

This pull request adds TypeScript support to the plugin-compat example project using the fork-ts-checker-webpack-plugin. It modifies the rspack.config.js, package.json, and pnpm-lock.yaml files to include the plugin as a dev dependency and configures it in the webpack build. It also adds a tsconfig.json file and a sample TypeScript file secret.ts that is imported by the index.js file.

Walkthrough

馃 Generated by Copilot at 1b8237a

  • Add fork-ts-checker-webpack-plugin as a dev dependency to improve TypeScript type checking during webpack compilation (link, link, link, link)
  • Import and enable the plugin in the rspack.config.js file (link, link)
  • Add a tsconfig.json file to configure TypeScript options and files for the plugin (link)
  • Import a TypeScript file secret.ts from the JavaScript entry point index.js to demonstrate the plugin functionality (link, link)
  • Update the versions of some sub-dependencies of the project to match the ones required by the plugin, such as @babel/code-frame and semver (link, link, link, link, link, link, link, link, link)
  • Add a new sub-dependency node-abort-controller that is used by the plugin to cancel asynchronous operations (link)
  • Remove the dev: false flag from some sub-dependencies of the project that are now considered dev dependencies by default due to the plugin (link)

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 23, 2023
@hardfist hardfist enabled auto-merge May 23, 2023 13:20
@hardfist hardfist added this pull request to the merge queue May 23, 2023
@hardfist hardfist added the need documentation Create a tracking issue in rspack-website label May 23, 2023
Merged via the queue into main with commit e271998 May 23, 2023
12 checks passed
@hardfist hardfist deleted the add-forkts branch May 23, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need documentation Create a tracking issue in rspack-website team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants