Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Use proxy config in the preview command #3287

Merged
merged 1 commit into from
May 24, 2023

Conversation

salamaashoush
Copy link
Contributor

@salamaashoush salamaashoush commented May 24, 2023

Summary

Use devServer proxy configs for the preview command

馃 Generated by Copilot at 494aae3

This pull request fixes a bug in the @rspack/cli package that prevented the preview command from using the proxy settings from the rspack config file. It updates the preview.ts file and adds a changeset file to document the patch update.

Walkthrough

馃 Generated by Copilot at 494aae3

  • Add a changeset file to document the patch update for the @rspack/cli package (link)
  • Enable the preview command to use the proxy option from the devServer section of the rspack config file (link)

@CLAassistant
Copy link

CLAassistant commented May 24, 2023

CLA assistant check
All committers have signed the CLA.

@hardfist
Copy link
Contributor

thanks

@hardfist hardfist enabled auto-merge May 24, 2023 14:50
@hardfist hardfist added this pull request to the merge queue May 24, 2023
Merged via the queue into web-infra-dev:main with commit 2475e4a May 24, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants