chore: avoid config check in webpack-test && add external test #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
IWANABETHATGUY
previously approved these changes
May 26, 2023
hardfist
force-pushed
the
webpack-test-external1
branch
2 times, most recently
from
6b1f207
to
9241cf1
Compare
Boshen
previously approved these changes
May 26, 2023
IWANABETHATGUY
previously approved these changes
May 26, 2023
hardfist
force-pushed
the
webpack-test-external1
branch
from
9241cf1
to
b106f01
Compare
Boshen
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
Summary
馃 Generated by Copilot at 4552108
This pull request enables and updates some test cases for the externals feature of rspack, and adds a setup file to configure the rspack validation mode for the tests. It modifies
test.filter.jsfiles inexternals/globalandexternals/thisconfig cases, and addssetupFilestopackage.jsonandsetupEnv.jstowebpack-test.Walkthrough
馃 Generated by Copilot at 4552108
test.filter.jsfiles to returntrue(link, link)setupFilesproperty topackage.jsonto specify asetupEnv.jsfile for jest tests (link)RSPACK_CONFIG_VALIDATEenvironment variable toloose-silentinsetupEnv.jsto avoid validation errors or warnings in test cases (link)