chore(window): support window test #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suxin2017
requested review from
hardfist,
IWANABETHATGUY and
h-a-n-a
as code owners
hardfist
reviewed
May 30, 2023
hardfist
previously approved these changes
May 30, 2023
hardfist
reviewed
May 30, 2023
hardfist
approved these changes
May 30, 2023
hardfist
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
Summary
馃 Generated by Copilot at d8a308b
This pull request improves the compatibility of the rspack library and its tests with Windows. It normalizes the asset paths, enforces the line endings, fixes the environment variables, and adjusts the GitHub workflows to run the tests on Windows. It uses the
cross-envpackage and a helper functiontransformWindowPathto handle the platform differences.Walkthrough
馃 Generated by Copilot at d8a308b
cross-envpackage to various scripts to set environment variables correctly on Windows (link, link, link)false &&condition fromifstatement in.github/workflows/reusable-build.ymlto enable test forx86_64-pc-windows-msvctarget (link)x86_64-unknown-linux-gnutox86_64-pc-windows-msvcin.github/workflows/test.ymlto focus on Windows tests (link)transformWindowPathfunction toreadAssets.jsto replace forward slashes with backslashes in asset paths on Windows (link, link)MultiCompiler.test.tsto avoid memory issues and timeouts on Windows (link, link).gitattributesto enforce LF line endings for some files and folders (link)