Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack-test): remove deprecated array ["jam", "main"] from mainFields #3334

Merged
merged 1 commit into from
May 29, 2023

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented May 29, 2023

closes #3328

Summary

jam is a ancient package manager, a remnant from Webpack 1. We can safely remove because the official webpack doc only supports array for mainFields. https://webpack.js.org/configuration/resolve/#resolvemainfields

🤖 Generated by Copilot at 7c2fba4

Remove an incompatible test case from webpack-test/TestCases.template.js. This fixes a test failure caused by the new output.library.type option in webpack.

Walkthrough

🤖 Generated by Copilot at 7c2fba4

  • Remove invalid test case for output.library.type and output.library.name (link)

@github-actions github-actions bot added release: bug fix team The issue/pr is created by the member of Rspack. labels May 29, 2023
@hardfist hardfist added this pull request to the merge queue May 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2023
@Boshen Boshen added this pull request to the merge queue May 29, 2023
Merged via the queue into main with commit 6c36a7c May 29, 2023
18 checks passed
@Boshen Boshen deleted the webpack-test-main-fields branch May 29, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack Test: Failed to convert JavaScript value Object ["jam","main"] into rust type String
2 participants