fix: builtins.provide function params transform bug #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: bug fix
team
jerrykingxyz
force-pushed
the
jerry/provide
branch
from
d05c84d
to
b4c9d4e
Compare
hyf0
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
Summary
馃 Generated by Copilot at d05c84d
This pull request enhances the provide plugin for JavaScript, which resolves unresolved identifiers with built-in modules. It improves the plugin's logic and performance, adds a new test case, and updates the existing test cases to cover more scenarios. The changes affect the
provide.rsfile, thecrates/rspack_plugin_javascript/tests/fixtures/providefolder, and thepackages/rspack/tests/configCases/builtins/providefolder.Walkthrough
馃 Generated by Copilot at d05c84d
crates/rspack_plugin_javascript/tests/fixtures/provide/index.js,crates/rspack_plugin_javascript/tests/fixtures/provide/expected/main.js, link, link)packages/rspack/tests/configCases/builtins/provide/index.js, link)