fix: before resolve can't modify data #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: bug fix
team
IWANABETHATGUY
requested review from
hardfist,
ahabhgk,
h-a-n-a and
hyf0
as code owners
IWANABETHATGUY
commented
May 31, 2023
IWANABETHATGUY
force-pushed
the
fix/before_resolve
branch
from
9392d0e
to
a65c14f
Compare
ahabhgk
approved these changes
May 31, 2023
IWANABETHATGUY
force-pushed
the
fix/before_resolve
branch
from
a65c14f
to
ab66efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
Closed #3320
Summary
馃 Generated by Copilot at 71c1bf0
This pull request adds the ability to modify the request string of module dependencies, which can affect how they are resolved by different plugins. It implements a
set_requestmethod for various dependency types that implement theModuleDependencytrait, and passes the request string to the module graph and the module factory. It also adds a new dependency type for dynamic imports in ESM modules, which is not fully implemented yet.Walkthrough
馃 Generated by Copilot at 71c1bf0
set_requestmethod to theModuleDependencytrait and its implementations (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)NormalModuleFactoryto pass a mutable reference to thedataparameter to thebefore_resolvehook (link, link)set_requestmethod to theModuleGraphModuleDependencystruct (link)