fix: fix wrong context in external function #3370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
Summary
馃 Generated by Copilot at 4518bd7
This pull request adds a
context
field to the structs and arguments used for module creation and dependency resolution. This improves the performance and reliability of theExternalPlugin
and allows it to access the directory of the module that requires the dependency.Walkthrough
馃 Generated by Copilot at 4518bd7
context
field toNormalModuleFactoryCreateData
to pass the directory of the module that requires the dependency (link)context
field toExternalPluginArgs
to pass the reference to thecontext
field fromNormalModuleFactoryCreateData
to theExternalPlugin
(link)context
field fromExternalPluginArgs
instead of deriving it fromrequest
inExternalPlugin
implementation inplugin.rs
(link)expect
call to ensurecontext
field is present and provide a more informative error message inExternalPlugin
implementation inplugin.rs
(link)