fix: fix wrong context in external function #3372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
Summary
馃 Generated by Copilot at 4c6cea2
This pull request adds a
context
field to the structs and arguments that are used for module creation and plugin application. This allows plugins to resolve external dependencies based on the directory where the module request originated from.Walkthrough
馃 Generated by Copilot at 4c6cea2
context
field toNormalModuleFactoryCreateData
andPluginArgs
structs to pass the module request origin directory to theNormalModuleFactory
and the plugins (link, link)context
field fromPluginArgs
to resolve external dependencies with custom functions instead of deriving it from therequest
string, and panic ifcontext
isNone
incrates/rspack_plugin_externals/src/plugin.rs
(link)use std::fmt::Debug
statement fromcrates/rspack_plugin_externals/src/plugin.rs
tocrates/rspack_core/src/normal_module_factory.rs
where it is needed for theExternalItemFnCtx
struct (link)