fix(commonjs_scanner): ignore unresolve require span #3591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #3558
Summary
Given a test case like this:
Rspack expects
require
andrequire.resolve
should not be replaced by__webpack_require__
as therequire
variable is not the one provided by runtime. In previous PR,require
will be kept, howeverrequire
in member expression likerequire.resolve
is replaced by mistake. This PR fixes this issue.Test Plan
See test cases.