Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): zod schema for output #3595

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

xinxinhe1810
Copy link
Contributor

@xinxinhe1810 xinxinhe1810 commented Jun 20, 2023

Related issue (if exists)
#3437

Summary

there are still some fields of Rspack configuration that are loose, we should make them complete.

finish the output some field, and not handle the module.
image

so not delete the output in _rewrite.ts.

Test Plan

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2023

CLA assistant check
All committers have signed the CLA.

@hyf0
Copy link
Collaborator

hyf0 commented Jun 22, 2023

CI failed.

Copy link
Collaborator

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hyf0 hyf0 added this pull request to the merge queue Jun 28, 2023
Merged via the queue into web-infra-dev:main with commit f767fd3 Jun 28, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants